Add new targets: buffer, buffer-before-point and buffer-after point. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll have to rebase on top of the current |
|
Yep, I'll do that later. |
bbatsov
reviewed
Sep 13, 2018
| @@ -214,6 +214,37 @@ | |||
| (easy-kill-thing 'list) | |||
| (should (string= "dummy" (easy-kill-candidate)))))) | |||
|
|
|||
| (ert-deftest test-easy-kill-on-buffer () | |||
There was a problem hiding this comment.
I'd split this test into 3 tests. I think this will make it more readable and will show better what exactly is being tested.
bbatsov
reviewed
Sep 13, 2018
| @@ -744,6 +747,31 @@ inspected." | |||
| (setf (easy-kill-get thing) 'sexp))) | |||
| (_ (easy-kill-thing 'sexp n t)))) | |||
|
|
|||
| (defun easy-kill-on-buffer (n) | |||
There was a problem hiding this comment.
Please add some docstrings for the new functions. I know they are simple, but still.
|
I think you should also add some "Unreleased" section to the News and mention the changes there as well. |
|
@knu Ping :-) |
|
Interested in this. Will it get finished? |
|
@knu another friendly ping. :) |
|
Sorry, I haven't been able to invest my time in this project. Please use my easy-kill-extras package for now and I'd really appreciate if someone could help me improve this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.